On Fri, Feb 1, 2019 at 5:14 PM Rémy Maucherat <r...@apache.org> wrote:
> On Fri, Feb 1, 2019 at 4:50 PM Mark Thomas <ma...@apache.org> wrote: > >> On 01/02/2019 14:41, Rémy Maucherat wrote: >> > On Thu, Jan 31, 2019 at 8:09 PM Mark Thomas <ma...@apache.org> wrote: >> > >> >> On 31/01/2019 16:31, Mark Thomas wrote: >> >>> On 31/01/2019 15:58, Rémy Maucherat wrote: >> >>>> On Wed, Jan 30, 2019 at 8:37 PM Mark Thomas <ma...@apache.org> >> wrote: >> >> >> <snip/> >> >> >>>> I had four issues then that appear to be fixed (three fixes and one >> test >> >>>> gone, which was >> >>>> com.sun.ts.tests.websocket.ee >> >> .javax.websocket.handshakeresponse.getHeadersHasOriginTest). >> >>>> com/sun/ts/tests/websocket/ee/javax/websocket/session/setTimeout1Test >> >>>> doesn't pass for me at the moment, although you put in your wiki it >> is >> >>>> fixed. >> >>> >> >>> I'm not 100% sure on that. It might be intermittent. Once I'd been >> >>> through everything once, I was going to do a full run and see where >> >>> things stand. >> >> >> >> Got to the bottom of that one (and 2 others). It was related to how >> >> quickly we checked for session timeout. The default is every 10s which >> >> isn't fast enough for those tests. I've added a system property to >> >> reduce it to every second and that fixes them. >> >> >> > >> > Hum, right, I think I remember that one now. It was a while ago. >> >> Maybe not. Those two are failing consistently for me now. >> > > Will have to look at it again then. > Ok, I think I was completely ignoring the Tomcat client back then, instead using Tyrus, to avoid mixing client and server issues together. So after investigating, it looks like a race condition on the session being in the process of being closed and a message being received by the client concurrently. I put a proposal in the wiki (all tests pass with it). Rémy
