Github user kkolinko commented on the issue:
https://github.com/apache/tomcat/pull/137
> The changes to package.html and similar look good.
The doctype declaration in package.html says HTML 3.2 and I that version
does not have the lang attribute on HTML element. HTML 4.01 DTD has the lang
attribute, so files using that specification are OK.
Anyway, those package.html files are just fragments consumed by javadoc
tool. I suspect that changing the attributes of the HTML element does not have
any effect on generated Javadoc documentation, but it needs testing.
> The changes to to anything under webapps/ needs to be considered in the
context of the work to improve localisation
I agree.
404/403/401.jsp pages in manager and host-manager may benefit from
localization, and in that case the lang attribute has to be calculated
dynamically to reflect the actual language being used. Though currently those
pages are hard-coded with some English text.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
