Chris, On Tue, Jan 22, 2019 at 7:16 PM Christopher Schultz < ch...@christopherschultz.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Igal, > > On 1/22/19 14:31, Igal Sapir wrote: > > On Tue, Jan 22, 2019 at 11:09 AM Mark Thomas <ma...@apache.org> > > wrote: > > > >> On 22/01/2019 18:13, Christopher Schultz wrote: > >>> All, > >>> > >>> Would it be okay to link to another web site -- specifically, > >>> Wikipedia -- in the Tomcat documentation? > >>> > >>> I'd like to link to the page on "block cipher modes" from the > >>> EncryptInterceptor documentation. > >>> > >>> We have links to Oracle's documentation, so I'm guessing this > >>> would be okay, but I wanted to check. > >> > >> I can't think of any reason not to. > >> > > > > I think that as a policy though, the links should be "nofollow", or > > else we will start receiving pull requests from random sources who > > would want to get a link to their sites. Follow links from the > > Tomcat site and/or documentation can be very valuable for SEO > > purposes, and if users would think that they can sneak in a link > > they would do so. > > I'm happy to use "nofollow", but the links are directly in the XML and > not generated, so anyone can still issue a PR with their own link in > it. It's up to us to police it. > > > While Wikipedia and the Oracle site are fine with regular links, > > making this a "policy" will help avoid the future discussions about > > which link qualifies for a "follow" link. > > Maybe we can add a rule to checkstyle to reject any external links > that don't point to some whitelist of sites like Oracle, Eclipse (EE), > and Wikipedia (or whatever). > +1 That's a good solution if it can be implemented rather easily, e.g. with Regex or something like that. Best, Igal
