On Wed, Dec 5, 2018 at 9:17 PM Mark Thomas <ma...@apache.org> wrote: > On 05/12/2018 20:03, Rémy Maucherat wrote: > > On Wed, Dec 5, 2018 at 5:37 PM <r...@apache.org> wrote: > > > >> Author: remm > >> Date: Wed Dec 5 16:37:42 2018 > >> New Revision: 1848225 > >> > >> URL: http://svn.apache.org/viewvc?rev=1848225&view=rev > >> Log: > >> Add i18n for the loader package. > >> > >> I have at least 350 more strings to add. > > > > I don't know what to do with: > > - the bootstrap.jar strings: nothing ? > > Refactor StringManager to JULI? It is somewhat logging related so that > doesn't seem completely crazy. >
Ok, why not. > > > - the "upstream" strings: dbcp, pool, bcel, fileupload > > We could 'fix' them. It would mean the code diverging further from the > original which will make syncing harder. Roughly how many Strings are we > talking about here? > About 200. Rémy
