Author: remm Date: Sat Nov 17 13:59:49 2018 New Revision: 1846802 URL: http://svn.apache.org/viewvc?rev=1846802&view=rev Log: Switch utility threads to non daemon by default, as it makes things nicer when embedding (no need to use a thread to await) and the lifecycle is properly managed at the Service level (the threads are only stopped on destroy).
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardService.java tomcat/trunk/webapps/docs/changelog.xml tomcat/trunk/webapps/docs/config/service.xml Modified: tomcat/trunk/java/org/apache/catalina/core/StandardService.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardService.java?rev=1846802&r1=1846801&r2=1846802&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/core/StandardService.java (original) +++ tomcat/trunk/java/org/apache/catalina/core/StandardService.java Sat Nov 17 13:59:49 2018 @@ -101,7 +101,7 @@ public class StandardService extends Lif /** * The utility threads daemon flag. */ - protected boolean utilityThreadsAsDaemon = true; + protected boolean utilityThreadsAsDaemon = false; /** * Utility executor with scheduling capabilities. Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1846802&r1=1846801&r2=1846802&view=diff ============================================================================== --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Sat Nov 17 13:59:49 2018 @@ -66,7 +66,8 @@ </fix> <add> Add a scheduled executor to the Service, which can be used to - process periodic utility tasks. (remm) + process periodic utility tasks. The utility threads are non daemon + by default. (remm) </add> <update> Refactor container background processor using the Service executor, and Modified: tomcat/trunk/webapps/docs/config/service.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/service.xml?rev=1846802&r1=1846801&r2=1846802&view=diff ============================================================================== --- tomcat/trunk/webapps/docs/config/service.xml (original) +++ tomcat/trunk/webapps/docs/config/service.xml Sat Nov 17 13:59:49 2018 @@ -94,7 +94,7 @@ <attribute name="utilityThreadsAsDaemon" required="false"> <p>Set the daemon flag value for the utility threads. The default value - is <code>true</code>. + is <code>false</code>. </p> </attribute> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org