On Tue, Oct 9, 2018 at 9:05 PM Mark Thomas <ma...@apache.org> wrote: > On 09/10/18 19:58, Rémy Maucherat wrote: > > On Tue, Oct 9, 2018 at 8:56 PM Mark Thomas <ma...@apache.org> wrote: > > > >> On 09/10/18 19:55, ma...@apache.org wrote: > >>> Author: markt > >>> Date: Tue Oct 9 18:55:17 2018 > >>> New Revision: 1843328 > >>> > >>> URL: http://svn.apache.org/viewvc?rev=1843328&view=rev > >>> Log: > >>> Fix unused code warning > >> > >> My IDE popped up a warning that this parameter was unused. I think I > >> have fixed this correctly but additional review would be good here. > >> > > > > Good idea. My own IDE never cares about anything. > > Some further testing suggests my change wasn't what was intended (since > there is a hard-coded default of "RSA" set further up the stack and that > is an invalid value here). Was was intended? I can't see anywhere else > where clientKeyAlgo could be used. >
Ok, so it's because the jgroups code doesn't use our PEMFile to get the private key, and it tries three key algorithms until it works. I can add the ability in the PEMFile to pass that parameter (one extra constructor), or forget about it and keep it as is. Rémy
