On 10/4/2018 2:21 PM, Igal Sapir wrote:
On 10/3/2018 2:29 AM, Mark Thomas wrote:
On 02/10/18 20:40, Igal Sapir wrote:
On 02/10/18 06:58, Igal Sapir wrote:
When trying to run the unit test cases with `ant clean test` on the
current
trunk [1] I am getting two (per connector) failures:

org.apache.tomcat.util.net.openssl.ciphers.TestCipher FAILED [2]

org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser

FAILED [3]

<snip/>
These tests are all particularly sensitive to the versions of OpenSSL,
Java and the implementation of Java used.

Generally, those tests are there to ensure that the code that translates
between JSSE cipher definitions and OpenSSL definitions is correct.

If you see a failure it may indicate that:

- the test has a bug
<snip/>
On the Linux box I have OpenSSL installed and on the PATH.  On Windows I
used version OpenSSL 1.1.1  11 Sep 2018 and specified it via the
`test.openssl.path` property.  I checked the value of
`test.openssl.exists` and it showed the expected `true`.  Both Windows
and Fedora generated an output file for
test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java [1]. Both,
however, reported "Found OpenSSL version 0x0" which I find strange?
That does seem odd. I suspect either the wrong OpenSSL version or no
OpenSSL version was found.

Gump was also showing "version 0x0" [1].

System.load() [2] was throwing an error that an absolute path is expected, but that error was ignored at [3] so we didn't see it. I added a warning to the log in r1842849 [4].

Igal

OK, so now without tcnative in the bin directory I get:

04-Oct-2018 14:33:24.483 INFO [main] org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case [testOpenSSLConfCmdCipher] 04-Oct-2018 14:33:24.823 WARNING [main] org.apache.tomcat.util.net.openssl.TestOpenSSLConf.testOpenSSLConfCmdCipher OpenSSL not found: Can't load library: e:\Workspace\git\tomcat\bin\tcnative-1.dll, Can't load library: e:\Workspace\git\tomcat\bin\libtcnative-1.dll, no tcnative-1 in java.library.path, no libtcnative-1 in java.library.path

And with tcnative I get:

04-Oct-2018 14:52:14.231 INFO [main] org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case [testOpenSSLConfCmdCipher] 04-Oct-2018 14:52:14.434 INFO [main] org.apache.tomcat.util.net.openssl.TestOpenSSLConf.testOpenSSLConfCmdCipher Found OpenSSL version 0x100020ff

Which makes much more sense.  Is there a reason that the OpenSSL version is printed in Hex?

Igal



[1] http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio/gump_file/TEST-org.apache.tomcat.util.net.openssl.TestOpenSSLConf.NIO.txt.html

[2] http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/jni/Library.java?revision=1834660&view=markup&pathrev=1842849#l42

[3] http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/net/TesterSupport.java?view=markup&pathrev=1842748#l91

[4] http://svn.apache.org/viewvc?rev=1842849&view=rev


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to