Author: markt Date: Sun Aug 26 19:27:56 2018 New Revision: 1839244 URL: http://svn.apache.org/viewvc?rev=1839244&view=rev Log: Fix potential resource leak reported by Coverity
Modified: tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java Modified: tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java?rev=1839244&r1=1839243&r2=1839244&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java (original) +++ tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java Sun Aug 26 19:27:56 2018 @@ -371,9 +371,8 @@ public class ErrorReportValve extends Va response.setContentType("text/html"); response.setCharacterEncoding("UTF-8"); - try { - OutputStream os = response.getOutputStream(); - InputStream is = new FileInputStream(file); + try (OutputStream os = response.getOutputStream(); + InputStream is = new FileInputStream(file);){ IOTools.flow(is, os); } catch (IOException e) { getContainer().getLogger().warn( --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org