Author: markt
Date: Sun Aug 26 19:13:40 2018
New Revision: 1839241
URL: http://svn.apache.org/viewvc?rev=1839241&view=rev
Log:
Fix a false positive
Modified:
tomcat/tc8.5.x/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/tc8.5.x/trunk/res/findbugs/filter-false-positives.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/res/findbugs/filter-false-positives.xml?rev=1839241&r1=1839240&r2=1839241&view=diff
==============================================================================
--- tomcat/tc8.5.x/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/tc8.5.x/trunk/res/findbugs/filter-false-positives.xml Sun Aug 26
19:13:40 2018
@@ -583,6 +583,13 @@
<Bug code="Dm" />
</Match>
<Match>
+ <!-- Yes this is a dead store. This is so the IDE warning can be
suppressed.
+ The object creation has side-effects so the code is required. -->
+ <Class name="org.apache.jasper.compiler.JspDocumentParser" />
+ <Method name="comment"/>
+ <Bug pattern="DLS_DEAD_LOCAL_STORE"/>
+ </Match>
+ <Match>
<!-- Node constructors add node to parent. Local variable is used to
silence an Eclipse warning -->
<Class name="org.apache.jasper.compiler.ELFunctionMapper"/>
@@ -591,6 +598,12 @@
</Match>
<Match>
<!-- NPE is not possible -->
+ <Class name="org.apache.jasper.compiler.JspConfig"/>
+ <Method name="selectProperty"/>
+ <Bug code="NP"/>
+ </Match>
+ <Match>
+ <!-- NPE is not possible -->
<Class name="org.apache.jasper.compiler.JspConfig"/>
<Method name="selectProperty"/>
<Bug code="NP"/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
