https://bz.apache.org/bugzilla/show_bug.cgi?id=52381

--- Comment #16 from Mark Thomas <ma...@apache.org> ---
I have a few comments but keep in mind my minimal OSGI knowledge:

- I see placeholders %bundleProvider, %bundleName etc. nut nothing to populate
them

- The execution environments look wrong given the java version they are
compiled for

- The imports for jasper.jar look to be too wide. org.apache.commons.el, for
example, is an old UEL implementation that Tomcat shouldn't (and doesn't as far
as I know) depend on

- version numbers need updating for Tomcat 9 (Servlet 4.0)

I also compared the the patch to the manifests provided in the latest Eclipse
Virgo release. There are a lot of differences. I'm not sure how significant
they are.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to