Author: markt
Date: Fri May 25 07:08:11 2018
New Revision: 1832217

URL: http://svn.apache.org/viewvc?rev=1832217&view=rev
Log:
After sleeping on it, correct usage is more important than 100% code coverage

Modified:
    tomcat/trunk/java/org/apache/tomcat/util/http/parser/Authorization.java
    
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestAuthorizationDigest.java

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/http/parser/Authorization.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/parser/Authorization.java?rev=1832217&r1=1832216&r2=1832217&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/http/parser/Authorization.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/http/parser/Authorization.java Fri 
May 25 07:08:11 2018
@@ -51,6 +51,12 @@ public class Authorization {
 
     }
 
+
+    private Authorization() {
+        // Utility class. Hide default constructor.
+    }
+
+
     /**
      * Parses an HTTP Authorization header for DIGEST authentication as per RFC
      * 2617 section 3.2.2.

Modified: 
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestAuthorizationDigest.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestAuthorizationDigest.java?rev=1832217&r1=1832216&r2=1832217&view=diff
==============================================================================
--- 
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestAuthorizationDigest.java
 (original)
+++ 
tomcat/trunk/test/org/apache/tomcat/util/http/parser/TestAuthorizationDigest.java
 Fri May 25 07:08:11 2018
@@ -341,10 +341,4 @@ public class TestAuthorizationDigest {
         Map<String,String> result = 
Authorization.parseAuthorizationDigest(input);
         Assert.assertNull(result);
     }
-
-    @Test
-    public void testCoverage() {
-        // Here to add code coverage of default constructor
-        Assert.assertNotNull(new Authorization());
-    }
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to