Author: markt
Date: Mon May 14 15:17:39 2018
New Revision: 1831581
URL: http://svn.apache.org/viewvc?rev=1831581&view=rev
Log:
Fix some false positives
Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1831581&r1=1831580&r2=1831581&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Mon May 14 15:17:39
2018
@@ -1007,6 +1007,20 @@
<Bug pattern="VO_VOLATILE_INCREMENT" />
</Match>
<Match>
+ <!-- Fields do not need to be sync'd for toString() -->
+ <Class name="org.apache.tomcat.dbcp.pool2.impl.SoftReferenceObjectPool" />
+ <Or>
+ <Field name="createCount"/>
+ <Field name="numActive"/>
+ </Or>
+ <Bug pattern="IS2_INCONSISTENT_SYNC" />
+ </Match>
+ <Match>
+ <!-- Public API is a design decision of Commons -->
+ <Class name="org.apache.tomcat.dbcp.pool2.impl.SoftReferenceObjectPool" />
+ <Bug pattern="PS_PUBLIC_SEMAPHORES" />
+ </Match>
+ <Match>
<!-- Return value is ignored but a null result will trigger an exception
-->
<Class name="org.apache.tomcat.jdbc.pool.ConnectionPool$ConnectionFuture"
/>
<Method name="get" />
@@ -1066,6 +1080,12 @@
<Bug code="VO" />
</Match>
<Match>
+ <!-- Fields are used by native code. Tomcat doesn't use them but they are
+ part of the public API. -->
+ <Class name="org.apache.tomcat.jni.Sockaddr" />
+ <Bug pattern="UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD" />
+ </Match>
+ <Match>
<Class name="org.apache.tomcat.util.IntrospectionUtils" />
<Method name="findMethod"/>
<Bug code="NP" />
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
