Author: markt
Date: Thu Apr 5 09:54:44 2018
New Revision: 1828408
URL: http://svn.apache.org/viewvc?rev=1828408&view=rev
Log:
SpotBugs
More false positives
Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1828408&r1=1828407&r2=1828408&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Thu Apr 5 09:54:44
2018
@@ -533,6 +533,11 @@
<Bug pattern="IS2_INCONSISTENT_SYNC"/>
</Match>
<Match>
+ <Class name="org.apache.catalina.tribes.group.RpcChannel"/>
+ <Method name="send"/>
+ <Bug pattern="WA_NOT_IN_LOOP"/>
+ </Match>
+ <Match>
<Class name="org.apache.catalina.tribes.membership.McastServiceImpl"/>
<Method name="stop"/>
<Bug code="DE"/>
@@ -563,12 +568,35 @@
<Bug pattern="UG_SYNC_SET_UNSYNC_GET"/>
</Match>
<Match>
+ <Class name="org.apache.catalina.tribes.membership.MemberImpl"/>
+ <Field name="dataPkg"/>
+ <Bug pattern="IS2_INCONSISTENT_SYNC"/>
+ </Match>
+ <Match>
+ <!-- Byte arrays contents are not mutated -->
+ <Class name="org.apache.catalina.tribes.membership.MemberImpl"/>
+ <Or>
+ <Field name="command"/>
+ <Field name="domain"/>
+ <Field name="host"/>
+ <Field name="payload"/>
+ <Field name="uniqueId"/>
+ </Or>
+ <Bug pattern="VO_VOLATILE_REFERENCE_TO_ARRAY"/>
+ </Match>
+ <Match>
<!-- lock is in clone so this is safe -->
<Class name="org.apache.catalina.tribes.membership.Membership" />
<Method name="clone" />
<Bug pattern="ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD" />
</Match>
<Match>
+ <!-- Byte arrays contents are not mutated -->
+ <Class name="org.apache.catalina.tribes.membership.Membership" />
+ <Field name="members"/>
+ <Bug pattern="VO_VOLATILE_REFERENCE_TO_ARRAY"/>
+ </Match>
+ <Match>
<!-- Fields are always recalculated on access -->
<Class
name="org.apache.catalina.tribes.tipis.AbstractReplicatedMap$MapMessage" />
<Or>
@@ -578,12 +606,34 @@
<Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
</Match>
<Match>
+ <!-- Sync is not intended to protect access to this field -->
+ <Class name="org.apache.catalina.tribes.transport.ReplicationTransmitter"/>
+ <Field name="oname"/>
+ <Bug pattern="IS2_INCONSISTENT_SYNC"/>
+ </Match>
+ <Match>
<!-- Intentional in case thread is waiting -->
<Class name="org.apache.catalina.tribes.transport.RxTaskPool"/>
<Method name="returnWorker"/>
<Bug code="NN"/>
</Match>
<Match>
+ <!-- Sync is to protect multiple against calls to connect() -->
+ <Class name="org.apache.catalina.tribes.transport.nio.NioSender"/>
+ <Or>
+ <Field name="dataChannel"/>
+ <Field name="socketChannel"/>
+ <Field name="writebuf"/>
+ </Or>
+ <Bug pattern="IS2_INCONSISTENT_SYNC"/>
+ </Match>
+ <Match>
+ <!-- Byte arrays contents are not mutated -->
+ <Class name="org.apache.catalina.tribes.transport.nio.NioSender"/>
+ <Field name="current"/>
+ <Bug pattern="VO_VOLATILE_REFERENCE_TO_ARRAY"/>
+ </Match>
+ <Match>
<Class name="org.apache.catalina.util.LifecycleBase" />
<Method name="getState"/>
<Bug code="UG" />
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
