GitHub user zemian opened a pull request:
https://github.com/apache/tomcat/pull/106
Fix cygpath is checking for empty path
Hi, When running Tomcat under Cygwin shell, I see `cygpath: can't convert
empty path` error message printed, but it will continue to work. Looking
closely, it seems that `catalina.sh` script didn't check for empty string for
the optional JAVA_ENDORSED_DIRS var before calling cygpath. I have created a PR
that fix this minor bug. Please review.
```
$ bin/catalina.sh version
cygpath: can't convert empty path
Using CATALINA_BASE: C:\Users\zemian\apps\apache-tomcat-8.5.29
Using CATALINA_HOME: C:\Users\zemian\apps\apache-tomcat-8.5.29
Using CATALINA_TMPDIR: C:\Users\zemian\apps\apache-tomcat-8.5.29\temp
Using JRE_HOME: C:\Users\zemian\apps\jdk-8u161
Using CLASSPATH:
C:\Users\zemian\apps\apache-tomcat-8.5.29\bin\bootstrap.jar;C:\Users\zemian\apps\apache-tomcat-8.5.29\bin\tomcat-juli.jar
Server version: Apache Tomcat/8.5.29
Server built: Mar 5 2018 13:11:12 UTC
Server number: 8.5.29.0
OS Name: Windows 7
OS Version: 6.1
Architecture: amd64
JVM Version: 1.8.0_161-b12
JVM Vendor: Oracle Corporation
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zemian/tomcat zemian_fix-cygpath
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit 2534d5c3e6359e700690168998d8bd25c273b9b1
Author: Zemian Deng <zemian.deng@...>
Date: 2018-04-04T14:43:02Z
Fix cygpath is checking for empty path
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
