-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Mark,
On 3/2/18 12:01 PM, ma...@apache.org wrote: > Author: markt Date: Fri Mar 2 17:01:35 2018 New Revision: 1825734 > > URL: http://svn.apache.org/viewvc?rev=1825734&view=rev Log: Add a > characterset to the JMX text output > > Modified: > tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java > > Modified: > tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java > URL: > http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/man ager/JMXProxyServlet.java?rev=1825734&r1=1825733&r2=1825734&view=diff > > ======================================================================== ====== > --- > tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java > (original) +++ > tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java > Fri Mar 2 17:01:35 2018 @@ -83,7 +83,7 @@ public class > JMXProxyServlet extends Htt @Override public void > doGet(HttpServletRequest request, HttpServletResponse response) > throws IOException, ServletException { - > response.setContentType("text/plain"); + > response.setContentType("text/plain;charset=" + > Constants.CHARSET); Would it be better to do this instead: response.setContentType("text/plain;charset=" + response.getCharacterEncoding()); Even if the encoding is *supposed* to be UTF-8 (like the constant suggests), in case it isn't for whatever reason, we should use the encoding that is actually being used, instead of what we expect to be used. - -chris -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQJRBAEBCAA7FiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlqZn4kdHGNocmlzQGNo cmlzdG9waGVyc2NodWx0ei5uZXQACgkQHPApP6U8pFgyKQ//RVH1zS19GHdPTnWq 0E4Q5y4Ifs2So2VIWzbypmgjHeSnfmlMsXM2/dI4SxdD8G3mOqruTF8NsSxbvya6 aS7jlywLeHNXgJ97NwK4ze9/FjJJTQi8khr1B5sVZzTgL9ZAH4JW2P5/l5Oh2ETm 8IRJgR75MKm21VvmOwgakYDr2SQJckyORDbAHdtPT1NtYJ93WhnLTEmBhT7+t46n b0zaSfYmusk/OPPimJljguXbkw0ydmirlpGXocEk9GFy59AdRmjNTCLSM/jQlzHx h94M29UxdIbf0/UNF/+sSTUyxrDtc8GHWTLUaCSiS7tFk/2fV8UnmQRNna/ZSZHF 1yiG1PDFQW+UXlx7JkUp7KUSM/bZgW64SI9Zvqu659VJ2xAcG70qk0VytTQA8CHO QXVTHrWn/6DuZ892JDPxafLeoWBA8DfGhZeVcSzGbXb5wFFRErZ0+OaiVe+OTTTD l4fyrDlH69x20fvIObt9twte2Da6dUMzA+FxxubEpORuGf9nKdl11EON9ot0B8LL EYay3E7isdMST2KeQVh0mVNxPW3qpStjxtF4p2Dwwke7h77gJp+1MXirUKrHmvGH 8azRKHdcVOd+8NeWLK34uQwDz30NH/X1SJmlySQ/hnyKN2udQTn7NEREfLk2AYbp sJL/URUtyE2X+PdaqpEHVwWAUWc= =4xK/ -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
