GitHub user px-stkn opened a pull request:

    https://github.com/apache/tomcat/pull/101

    Fix compressibleMimeType handling for compression="on"

    This change fixes a regression introduced by 913cb6d / r1816549
    "Refactor: Move compression code to new class to allow re-use with HTTP/2",
    which (among other things) consolidates isCompressible() and 
useCompression()
    into a single functions.
    
    Unfortunately, the call to getCompressibleMimeTypes(), got lost in the 
process,
    leaving the compressibleMimeTypes array uninitialized, disabling the 
mimetype check
    in useCompression(), effectively turning it into compression="force".
    
    Signed-off-by: Stefan Knoblich <s.knobl...@praxino.de>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/praxino/tomcat trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomcat/pull/101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #101
    
----
commit 44d903f60539f896f706092f68c3499676dde03a
Author: Stefan Knoblich <s.knoblich@...>
Date:   2018-02-27T12:38:58Z

    Fix compressibleMimeType handling for compression="on"
    
    This change fixes a regression introduced by 913cb6d / r1816549
    "Refactor: Move compression code to new class to allow re-use with HTTP/2",
    which (among other things) consolidates isCompressible() and 
useCompression()
    into a single functions.
    
    Unfortunately, the call to getCompressibleMimeTypes(), got lost in the 
process,
    leaving the compressibleMimeTypes array uninitialized, disabling the 
mimetype check
    in useCompression(), effectively turning it into compression="force".
    
    Signed-off-by: Stefan Knoblich <s.knobl...@praxino.de>

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to