Author: rjung
Date: Wed Feb 7 16:12:44 2018
New Revision: 1823492
URL: http://svn.apache.org/viewvc?rev=1823492&view=rev
Log:
Minor optimization when calling class tranformers.
The code was previously moved from another place
but can now be optimized.
Modified:
tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java
tomcat/trunk/webapps/docs/changelog.xml
Modified:
tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java?rev=1823492&r1=1823491&r2=1823492&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java Wed
Feb 7 16:12:44 2018
@@ -2198,9 +2198,10 @@ public abstract class WebappClassLoaderB
if (transformers.size() > 0) {
// If the resource is a class just being loaded, decorate it
// with any attached transformers
- String className = name.endsWith(CLASS_FILE_SUFFIX) ?
- name.substring(0, name.length() -
CLASS_FILE_SUFFIX.length()) : name;
- String internalName = className.replace(".", "/");
+
+ // Ignore leading '/' and trailing CLASS_FILE_SUFFIX
+ // Should be cheaper than replacing '.' by '/' in class name.
+ String internalName = path.substring(1, path.length() -
CLASS_FILE_SUFFIX.length());
for (ClassFileTransformer transformer : this.transformers) {
try {
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1823492&r1=1823491&r2=1823492&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Feb 7 16:12:44 2018
@@ -51,6 +51,9 @@
<bug>48672</bug>: Add documentation for the Host Manager web
application. Patch provided by Marek Czernek. (markt)
</add>
+ <fix>
+ Minor optimization when calling class tranformers. (rjung)
+ </fix>
</changelog>
</subsection>
</section>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
