Author: markt
Date: Thu Jan 11 13:19:27 2018
New Revision: 1820875
URL: http://svn.apache.org/viewvc?rev=1820875&view=rev
Log:
SpotBugs
Reduce visibility
Modified:
tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java
Modified: tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java?rev=1820875&r1=1820874&r2=1820875&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java [UTF-8]
(original)
+++ tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java [UTF-8] Thu Jan
11 13:19:27 2018
@@ -134,7 +134,7 @@ import org.apache.tomcat.util.security.P
*
|----------------------------------------------------------------------------|
* </pre>
*/
-public class AsyncStateMachine {
+class AsyncStateMachine {
/**
* The string manager for this package.
@@ -169,19 +169,19 @@ public class AsyncStateMachine {
this.isDispatching = isDispatching;
}
- public boolean isAsync() {
+ boolean isAsync() {
return isAsync;
}
- public boolean isStarted() {
+ boolean isStarted() {
return isStarted;
}
- public boolean isDispatching() {
+ boolean isDispatching() {
return isDispatching;
}
- public boolean isCompleting() {
+ boolean isCompleting() {
return isCompleting;
}
}
@@ -194,32 +194,32 @@ public class AsyncStateMachine {
private final AbstractProcessor processor;
- public AsyncStateMachine(AbstractProcessor processor) {
+ AsyncStateMachine(AbstractProcessor processor) {
this.processor = processor;
}
- public boolean isAsync() {
+ boolean isAsync() {
return state.isAsync();
}
- public boolean isAsyncDispatching() {
+ boolean isAsyncDispatching() {
return state.isDispatching();
}
- public boolean isAsyncStarted() {
+ boolean isAsyncStarted() {
return state.isStarted();
}
- public boolean isAsyncTimingOut() {
+ boolean isAsyncTimingOut() {
return state == AsyncState.TIMING_OUT;
}
- public boolean isAsyncError() {
+ boolean isAsyncError() {
return state == AsyncState.ERROR;
}
- public boolean isCompleting() {
+ boolean isCompleting() {
return state.isCompleting();
}
@@ -230,11 +230,11 @@ public class AsyncStateMachine {
* @return The time (as returned by {@link System#currentTimeMillis()})
that
* this connection last transitioned to async
*/
- public long getLastAsyncStart() {
+ long getLastAsyncStart() {
return lastAsyncStart;
}
- public synchronized void asyncStart(AsyncContextCallback asyncCtxt) {
+ synchronized void asyncStart(AsyncContextCallback asyncCtxt) {
if (state == AsyncState.DISPATCHED) {
state = AsyncState.STARTING;
this.asyncCtxt = asyncCtxt;
@@ -246,7 +246,7 @@ public class AsyncStateMachine {
}
}
- public synchronized void asyncOperation() {
+ synchronized void asyncOperation() {
if (state==AsyncState.STARTED) {
state = AsyncState.READ_WRITE_OP;
} else {
@@ -261,7 +261,7 @@ public class AsyncStateMachine {
* current state. For example, as per SRV.2.3.3.3 can now process calls to
* complete() or dispatch().
*/
- public synchronized SocketState asyncPostProcess() {
+ synchronized SocketState asyncPostProcess() {
if (state == AsyncState.COMPLETE_PENDING) {
doComplete();
return SocketState.ASYNC_END;
@@ -293,7 +293,7 @@ public class AsyncStateMachine {
}
- public synchronized boolean asyncComplete() {
+ synchronized boolean asyncComplete() {
if (!ContainerThreadMarker.isContainerThread() && state ==
AsyncState.STARTING) {
state = AsyncState.COMPLETE_PENDING;
return false;
@@ -321,7 +321,7 @@ public class AsyncStateMachine {
}
- public synchronized boolean asyncTimeout() {
+ synchronized boolean asyncTimeout() {
if (state == AsyncState.STARTED) {
state = AsyncState.TIMING_OUT;
return true;
@@ -339,7 +339,7 @@ public class AsyncStateMachine {
}
- public synchronized boolean asyncDispatch() {
+ synchronized boolean asyncDispatch() {
if (!ContainerThreadMarker.isContainerThread() && state ==
AsyncState.STARTING) {
state = AsyncState.DISPATCH_PENDING;
return false;
@@ -385,7 +385,7 @@ public class AsyncStateMachine {
}
- public synchronized void asyncDispatched() {
+ synchronized void asyncDispatched() {
if (state == AsyncState.DISPATCHING ||
state == AsyncState.MUST_DISPATCH) {
state = AsyncState.DISPATCHED;
@@ -397,7 +397,7 @@ public class AsyncStateMachine {
}
- public synchronized void asyncMustError() {
+ synchronized void asyncMustError() {
if (state == AsyncState.STARTED) {
clearNonBlockingListeners();
state = AsyncState.MUST_ERROR;
@@ -409,7 +409,7 @@ public class AsyncStateMachine {
}
- public synchronized void asyncError() {
+ synchronized void asyncError() {
if (state == AsyncState.STARTING ||
state == AsyncState.STARTED ||
state == AsyncState.DISPATCHED ||
@@ -427,7 +427,7 @@ public class AsyncStateMachine {
}
}
- public synchronized void asyncRun(Runnable runnable) {
+ synchronized void asyncRun(Runnable runnable) {
if (state == AsyncState.STARTING || state == AsyncState.STARTED ||
state == AsyncState.READ_WRITE_OP) {
// Execute the runnable using a container thread from the
@@ -468,7 +468,7 @@ public class AsyncStateMachine {
}
- public synchronized void recycle() {
+ synchronized void recycle() {
// Use lastAsyncStart to determine if this instance has been used since
// it was last recycled. If it hasn't there is no need to recycle again
// which saves the relatively expensive call to notifyAll()
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
