Author: markt
Date: Wed Jan 10 21:13:02 2018
New Revision: 1820792
URL: http://svn.apache.org/viewvc?rev=1820792&view=rev
Log:
More false positives
Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1820792&r1=1820791&r2=1820792&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Wed Jan 10 21:13:02
2018
@@ -174,12 +174,47 @@
<Bug code="RCN"/>
</Match>
<Match>
+ <!-- Exception caught deliberately -->
+ <Class name="org.apache.catalina.core.NamingContextListener" />
+ <Method name="constructEnvEntry" />
+ <Bug pattern="REC_CATCH_EXCEPTION" />
+ </Match>
+ <Match>
+ <!-- Code uses same approach as CopyOnWriteArrayList -->
+ <Class name="org.apache.catalina.core.StandardContext" />
+ <Field name="constraints" />
+ <Bug pattern="VO_VOLATILE_REFERENCE_TO_ARRAY" />
+ </Match>
+ <Match>
+ <!-- Sync is for lifecycle state, not CookieProcessor -->
+ <Class name="org.apache.catalina.core.StandardContext" />
+ <Field name="cookieProcessor" />
+ <Bug pattern="IS2_INCONSISTENT_SYNC" />
+ </Match>
+ <Match>
<!-- Have to trigger GC for leak detection to work. Clearly documented -->
<Class name="org.apache.catalina.core.StandardHost" />
<Method name="findReloadedContextMemoryLeaks" />
<Bug code="Dm" />
</Match>
<Match>
+ <!-- Sync not targeting these fields -->
+ <Class name="org.apache.catalina.core.StandardWrapper" />
+ <Or>
+ <Field name="multipartConfigElement" />
+ <Field name="servletClass" />
+ <Field name="swallowOutput" />
+ <Field name="unloadDelay" />
+ </Or>
+ <Bug pattern="IS2_INCONSISTENT_SYNC" />
+ </Match>
+ <Match>
+ <!-- There is only a single wait condition -->
+ <Class name="org.apache.catalina.core.StandardWrapper" />
+ <Method name="deallocate" />
+ <Bug pattern="NO_NOTIFY_NOT_NOTIFYALL" />
+ </Match>
+ <Match>
<!-- Sleep is of short duration and lock is required -->
<Class name="org.apache.catalina.core.StandardWrapper" />
<Method name="unload" />
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
