> It would be safer to use \uNNNN for non-ASCII characters in strings to > avoid depending on IDE encoding preference. > (\u00A3 for the pound currency character here.)
I agree. I will take that change. ------------------------------------------------------------------ Konstantin Kolinko <knst.koli...@gmail.com> 2017 Nov 29 (Wed) 00:25 Tomcat Developers List <dev@tomcat.apache.org> Re: svn commit: r1816544 - /tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java 2017-11-28 17:04 GMT+03:00 Martin Grigorov <mgrigo...@apache.org>: > On Tue, Nov 28, 2017 at 3:52 PM, <hux...@apache.org> wrote: > >> Author: huxing >> Date: Tue Nov 28 13:52:58 2017 >> New Revision: 1816544 >> >> URL: http://svn.apache.org/viewvc?rev=1816544&view=rev >> Log: >> Change file encoding to UTF-8 >> >> Modified: >> tomcat/trunk/test/org/apache/tomcat/websocket/ >> TestWebSocketFrameClient.java >> >> Modified: tomcat/trunk/test/org/apache/tomcat/websocket/ >> TestWebSocketFrameClient.java >> URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/ >> tomcat/websocket/TestWebSocketFrameClient.java?rev=1816544&r1=1816543&r2= >> 1816544&view=diff >> ============================================================ >> ================== >> --- >> tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java >> (original) >> +++ >> tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java >> Tue Nov 28 13:52:58 2017 >> @@ -145,7 +145,7 @@ public class TestWebSocketFrameClient ex >> SecurityCollection collection = new SecurityCollection(); >> collection.addPatternDecoded("/"); >> String utf8User = "test"; >> - String utf8Pass = "123£"; >> + String utf8Pass = "123£"; >> > > The old value looked better. It would be safer to use \uNNNN for non-ASCII characters in strings to avoid depending on IDE encoding preference. (\u00A3 for the pound currency character here.) Though it is likely that we have already used UTF-8 chars elsewhere. >> tomcat.addUser(utf8User, utf8Pass); >> tomcat.addRole(utf8User, ROLE); >> Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
