https://bz.apache.org/bugzilla/show_bug.cgi?id=61795
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #1 from Mark Thomas <ma...@apache.org> ---
The approach looks good to me.
a) The package private approach has been used in a few places. It is correct
that it isn't often the preferred approach.
b) Reflection might be the simplest option here.
c) Mocking is also an option although not one that is used very often.
d) A test with a Tomcat instance is often used - especially when the amount of
re-use possible means minimal additional test code needs to be written.
Ultimately it is your call. My own preference would be for b) or d) followed by
c) then a) but I'm not the one implementing this. If you have a strong
preference, go with that.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
