Author: markt Date: Tue Nov 21 15:08:54 2017 New Revision: 1815933 URL: http://svn.apache.org/viewvc?rev=1815933&view=rev Log: Follow-up to r1812551 Need to sync on state if calling state.notify() Reported by SpotBugs
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java?rev=1815933&r1=1815932&r2=1815933&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Tue Nov 21 15:08:54 2017 @@ -921,7 +921,7 @@ public class Nio2Endpoint extends Abstra ioe = new IOException(exc); } setError(ioe); - synchronized (this) { + synchronized (state) { readPending.release(); if (state.block == BlockingMode.BLOCK) { state.state = Nio2Endpoint.isInline() ? CompletionState.ERROR : CompletionState.DONE; --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org