On 16/11/17 14:05, Konstantin Kolinko wrote: > 2017-11-16 16:30 GMT+03:00 <ma...@apache.org>: >> Author: markt >> Date: Thu Nov 16 13:30:26 2017 >> New Revision: 1815451 >> >> URL: http://svn.apache.org/viewvc?rev=1815451&view=rev >> Log: >> Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61736 >> Improve performance of NIO connector when clients leave large time gaps >> between network packets. >> Patch provided by Zilong Song. >> This closes #81 >> >> Modified: >> tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java >> tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java >> tomcat/trunk/webapps/docs/changelog.xml >> >> Modified: >> tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java >> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java?rev=1815451&r1=1815450&r2=1815451&view=diff >> ============================================================================== >> --- tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java >> (original) >> +++ tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java >> Thu Nov 16 13:30:26 2017 >> @@ -263,10 +263,25 @@ public class NioBlockingSelector { >> boolean result = false; >> Runnable r = null; >> result = (events.size() > 0); > > I think that the above line can be removed, > or call size() once and save it in a local variable.
Agreed. I'll get that done. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
