On 15/10/17 20:09, Igal @ Lucee.org wrote: > On 10/15/2017 12:06 PM, Kapil Kumar wrote: >> Thanks, got you. Plain text emails only. >> >> Does that mean I could skip this part! > > If you didn't make any changes that can break Tomcat then you can skip > that part, yes. > > If you made changes that might have broken something, then this part > will test many known issues and alert you if something was "broken", > i.e. not working as expected due to your changes.
It can be hard to judge when it is a good idea to run tests and/or which tests to run - especially for someone new to the code base. A good starting point is run the unit tests for at least the NIO connector for every package where you have made changes. One thing I will say is don't worry about making mistakes. One of the hardest things to do working in open source is accepting that sometimes you get things wrong and when you do it happens in public in full view of everyone. It is worth ensuring you run the validate target after any changes as that will pick up a lot of the trivial formatting issues that can make patches more work to integrate. Also, don't forget to update the documentation if necessary and to add an entry to the changelog. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
