On 27/09/17 14:20, Rainer Jung wrote: > I drafted a patch available at > > http://home.apache.org/~rjung/patches/tc8-java-9-noendorsed.patch > > for TC 8.0.x. I can't really test on Windows. > > Basic ingredients: > > - For bat and sh do not try to remove the flag from the Java command, > and instead use a non existing system property ignore.endorsed.dirs > instead of java.endorsed.dirs if the user has not supplied a non-empty > JAVA_ENDORSED_DIRS and the endorsed sub directory of CATALINA_HOME does > not exist. I also did not replace the full flag including the value with > a variable to reduce chances of getting whitespace issues. It sounded > easiest to simply make the property name variable. > > - I refrained from Java version checking in the scripts. I think it is > better to not set endorsed if the user has not demanded it and the > directory wasn't created. And if the user demands it or the dir exists, > set it and fail on Java 9 so that it is clear that people have to clean > their installation up. > > - Removed the endorsed flag from the commandline that the NSI installer > registers for the service. This is mostly because I don't know enough > about how to add logic to the NSI. > > I have not directly committed it, because script file changes always > carry some potential of breaking stuff and I want to wait until the next > release is done. > > It would be great if people could do some testing on their platforms.
I like the approach. It is better that what I did in trunk which was to simply remove it entirely. I'll port your patch to 9.0.x and test it. Cheers, Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
