2017-09-24 12:45 GMT+03:00 Rainer Jung <rainer.j...@kippdata.de>:
> The current Gump failures during validate might be due to the following
> change in checkstyle:
>
> https://github.com/checkstyle/checkstyle/issues/5065
>
> Gump uses a snapshot of checkstyle.
>
> The complains should be mostly about additional separator lines e.g. between
> static and non-static imports from the same packages. Example:
>
> ...
> import static org.junit.Assert.assertEquals;
>
> import org.junit.Test;
> ...
>
> OK, if I clean those up? Or do we want to keep our formatting here?
I am OK to clean those, but I think checkstyle is wrong here.
Maybe there is a way to explicitly configure relative order of
"static" vs "non-static" imports in the same code (e.g. as separate
explicit groups). Which of those must be ordered first ("import static
org.junit" or "import org.junit") is debatable.
Also this is related to configuration instructions in
\res\ide-support\eclipse\java-compiler-errors-warnings.txt
[[[
# Java -> Code Style -> Organize Imports
==========================================
The following configuration of "Organize Imports" setting can be
recommended for a quick setup. The order is enforced by checkstyle, so for
the authoritative definition look at <module name="ImportOrder"> in
res/checkstyle/checkstyle.xml
- java
- javax
- async
- jsp2
- [static] org.junit
- org.junit
- [static] org
- org
- com
- util
]]]
With the above configuration "Organize Imports" command in Eclipse
places static and non-static imports into separate groups.
> Am 24.09.2017 um 01:15 schrieb Bill Barker:
>>
>> To whom it may engage...
>> This is an automated request, but not an unsolicited one. For
>> more information please visit http://gump.apache.org/nagged.html,
>> and/or contact the folk at gene...@gump.apache.org.
>>
>> Project tomcat-trunk-validate has an issue affecting its community
>> integration.
>> This issue affects 1 projects,
>> and has been outstanding for 11 runs.
>> The current state of this project is 'Failed', with reason 'Build Failed'.
>> For reference only, the following projects are affected by this:
>> - tomcat-trunk-validate : Tomcat 9.x, a web server implementing the
>> Java Servlet 4.0,
>> ...
>>
>>
>> Full details are available at:
>>
>> http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/index.html
>>
>> That said, some information snippets are provided here.
>>
>> The following annotations (debug/informational/warning/error messages)
>> were provided:
>> -DEBUG- Dependency on checkstyle exists, no need to add for property
>> checkstyle.jar.
>> -INFO- Failed with reason build failed
>>
>>
>>
>> The following work was performed:
>>
>> http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html
>> Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build)
>> Work ended in a state of : Failed
>> Elapsed: 37 secs
>> Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true
>> -Dbuild.sysclasspath=only org.apache.tools.ant.Main
>> -Dgump.merge=/srv/gump/public/gump/work/merge.xml
>> -Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs
>> -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-8.3-SNAPSHOT.jar
>> -Dexecute.validate=true validate
>> [Working Directory: /srv/gump/public/workspace/tomcat-trunk]
>> CLASSPATH:
>> /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-8.3-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20170924.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.7-SNAPSHOT.jar:/srv/g
>>
>> ump/public/workspace/apache-commons/logging/target/commons-logging-20170924.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20170924.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-24.0-jre-SNAPSHOT.jar
>> ---------------------------------------------
>> [checkstyle] [ERROR]
>> /srv/gump/public/workspace/tomcat-trunk/test/org/apache/el/TestValueExpressionImpl.java:34:
>> Extra separation in import group before 'org.junit.Test' [ImportOrder]
>> [checkstyle] [ERROR]
>> /srv/gump/public/workspace/tomcat-trunk/test/org/apache/el/lang/TestELArithmetic.java:26:
>> Extra separation in import group before 'org.junit.Assert' [ImportOrder]
>> [checkstyle] [ERROR]
>> /srv/gump/public/workspace/tomcat-trunk/test/org/apache/el/lang/TestELSupport.java:30:
>> Extra separation in import group before 'org.junit.Assert' [ImportOrder]
>> [checkstyle] [ERROR]
>> /srv/gump/public/workspace/tomcat-trunk/test/org/apache/el/parser/TestELParser.java:30:
>> Extra separation in import group before 'org.junit.Ignore' [ImportOrder]
>> [checkstyle] [ERROR]
>> /srv/gump/public/workspace/tomcat-trunk/test/org/apache/jasper/compiler/TestAttributeParser.java:24:
>> Extra separation in import group before 'org.junit.Test' [ImportOrder]
>> [checkstyle] [ERROR]
>> /srv/gump/public/workspace/tomcat-trunk/test/org/apache/jasper/compiler/TestCompiler.java:29:
>> Extra separation in import group before 'org.junit.Test' [ImportOrder]
>> [checkstyle] [ERROR]
>> /srv/gump/public/workspace/tomcat-trunk/test/org/apache/jasper/compiler/TestGenerator.java:36:
>> Extra separation in import group before 'org.junit.Assert' [ImportOrder]
>> [checkstyle] [ERROR]
>> /srv/gump/public/workspace/tomcat-trunk/test/org/apache/jasper/compiler/TestJspConfig.java:24:
[...]
>> BUILD FAILED
>> /srv/gump/public/workspace/tomcat-trunk/build.xml:546: Got 119 errors and
>> 0 warnings.
>>
>> Total time: 37 seconds
>> ---------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
