https://bz.apache.org/bugzilla/show_bug.cgi?id=61189
--- Comment #3 from Christopher Schultz <ch...@christopherschultz.net> ---
I don't like the use of unique names that don't have any meaning, like
`environment-variable-N`. Might I suggest one or the other of these schemes:
<init-param>
<param-name>environment-variables</param-name>
<param-value>
ENV_VAR_1=foo
ENV_VAR_2=bar
...
</param-value>
</init-param>
Or:
<init-param>
<param-name>environment-variable-ENV_VAR_1</param-name>
<param-value>foo</param-value>
</init-param>
<init-param>
<param-name>environment-variable-ENV_VAR_2</param-name>
<param-value>bar</param-value>
</init-param>
...
I think I'd prefer the former over the latter.
Second, I think it makes sense to strip whitespace from around the names and
values of the environment variables. Basically, just add ".trim()" to all of
your .substring() calls. This will solve silly problems like people placing
leading/trailing spaces around names/values/equal signs. XML allows a lot of
optional whitespace, and some editors (and humans) like to be verbose.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
