Author: markt
Date: Mon Jul 17 22:42:16 2017
New Revision: 1802226
URL: http://svn.apache.org/viewvc?rev=1802226&view=rev
Log:
Add clarifying comment
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Request.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=1802226&r1=1802225&r2=1802226&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/connector/Request.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Mon Jul 17
22:42:16 2017
@@ -2857,6 +2857,10 @@ public class Request implements HttpServ
partsParseException = e;
}
} finally {
+ // This might look odd but is correct. setParseFailedReason() only
+ // sets the failure reason if none is currently set. This code
could
+ // be more efficient but it is written this way to be robust with
+ // respect to changes in the remainder of the method.
if (partsParseException != null || !success) {
parameters.setParseFailedReason(FailReason.UNKNOWN);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
