Github user katya-stoycheva commented on a diff in the pull request:

    https://github.com/apache/tomcat/pull/69#discussion_r126873704
  
    --- Diff: test/org/apache/juli/TestFileHandlerNonRotatable.java ---
    @@ -0,0 +1,59 @@
    +package org.apache.juli;
    +
    +import static org.junit.Assert.assertTrue;
    +
    +import java.io.File;
    +
    +import org.apache.catalina.startup.LoggingBaseTest;
    +import org.junit.After;
    +import org.junit.BeforeClass;
    +import org.junit.Test;
    +
    +public class TestFileHandlerNonRotatable extends LoggingBaseTest {
    +    private FileHandler testHandler;
    +
    +    @BeforeClass
    +    public static void setUpPerTestClass() throws Exception {
    +        System.setProperty("java.util.logging.manager",
    +                "org.apache.juli.ClassLoaderLogManager");
    +        System.setProperty("java.util.logging.config.file",
    +                TestFileHandlerNonRotatable.class
    +                        .getResource("logging-non-rotatable.properties")
    +                        .getFile());
    +    }
    --- End diff --
    
    added a line to decode URL path but this behavior is different in IDE 
(Eclipse in my case) and command line so please test both to be sure everything 
works


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to