https://bz.apache.org/bugzilla/show_bug.cgi?id=61171
--- Comment #3 from Igal Sapir <d...@21solutions.net> --- (moving discussion from Github to the ticket): >I think more discussion is required on how to approach this. Specifically, >when should the offset be applied? I agree, and I was trying to find different options for this in order to initiate a discussion, but the way that Tomcat reads the config files and initializes objects via introspection really limits us here unless there is a major overhaul. Server has the value for portOffset, so a reference to it is required in order to calculate (port + portOffset) The process is somewhat like this: Connectors are initialized (no reference to Service or Server) Service is linked to the Connectors (still no reference to Server) Server is added to Service Point (3) is point where I took the portOffset from Server and applied it to the Connectors. >What is the impact on getters and setters? For example connector.setPort >(getPort ()) should be a NO-OP. At point (1) above the Connector's setPort() is called by the IntrospectionUtils with the values from server.xml. That can not be a NO-OP at that point as that would practically disable the Connector, but we can check if Service and Server are null or not (which they are at initialization) and perhaps do something different accordingly? Is it even possible/allowed to change the port after initialization? -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
