Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/63
>I think more discussion is required on how to approach this. Specifically,
when should the offset be applied?
@markt-asf I agree, and I was trying to find different options for this in
order to initiate a discussion, but the way that Tomcat reads the config files
and initializes objects via introspection really limits us here unless there is
a major overhaul.
The process is somewhat like this:
1) `Connector`s are initialized (no reference to `Service` or `Server`)
2) `Service` is linked to the `Connector`s (still no reference to `Server`)
3) `Server` is added to Service
Point (3) is point where I took the `portOffset` from Server and applied
it to the `Connector`s.
>What is the impact on getters and setters? For example connector.setPort
(getPort ()) should be a NO-OP.
At point (1) above the Connector's setPort() is called by the
IntrospectionUtils with the values from `server.xml`. That can not be a NO-OP
at that point as that would practically disable the Connector, but we can check
if `Service` and `Server` are null or not (which they are at initialization)
and perhaps do something different accordingly?
Is it even possible/allowed to change the port after initialization?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
