All, I wanted to provide a little more context to the SMAP changes I have started working on.
The primary driver for all of this is this bug: https://bz.apache.org/bugzilla/show_bug.cgi?id=49176 Particularly comment #4. Currently, the SMAP implementation is more generic than it needs to be for Jasper. I am currently working on removing those elements Jasper will never need. The SMAP is produced in String format as required for insertion into a .class file. My expectation is that the API will need modification to expose the SMAP in object form (details TBD). The SMAP will then be retained for each class and used in preference to the page nodes for constructing error pages. The final solution is far from fixed. I need to do some performance testing with the current page nodes solution so I can compare the SMAP approach. There are various design decisions still to be made: - cache SMAP vs read it from the .class file as required - cache all, some (LRU), none - cache SMAP with the compiler (like page nodes) or some new web application wide cache? - no access to page nodes means we'd also need to parse the source JSP/tag to display the source extract I hope this provides some useful context to my current commits. Thoughts / comments / suggestions welcome. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
