https://bz.apache.org/bugzilla/show_bug.cgi?id=60963
--- Comment #9 from Mark Thomas <ma...@apache.org> --- I've spent a little time looking at this. I can confirm that I see similar performance improvements with local testing. I can also confirm I have not observed any file locking. I haven't looked for other leaks but if there are any, I expect them to be simple to fix. The one thing that worries me about this patch is the degree to which it depends on the JVM internals. While this works with the current Oracle JVM, my concern is for JVMs from other vendors and future Oracle versions. I did take a quick look at the ZIP specification [1] and it appears it should be fairly simple to read the file names and data offsets from the local file headers. I wonder if writing a parser that extracts just the info we need and skips the rest might be a better option. Finally, there are a few changes in the patch that aren't strictly related to fixing the problem at hand. It is generally better to put that sort of clean-up in a separate patch (no need to re-submit this patch - the comment is more for future reference). [1] https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
