Author: markt Date: Mon Apr 3 09:56:06 2017 New Revision: 1789937 URL: http://svn.apache.org/viewvc?rev=1789937&view=rev Log: Correct a regression in the X to comma refactoring that broke JMX operations that take parameters.
Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/StringUtils.java tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/StringUtils.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/buf/StringUtils.java?rev=1789937&r1=1789936&r2=1789937&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/tomcat/util/buf/StringUtils.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/buf/StringUtils.java Mon Apr 3 09:56:06 2017 @@ -39,6 +39,11 @@ public final class StringUtils { } + public static void join(String[] array, char separator, StringBuilder sb) { + join(Arrays.asList(array), separator, sb); + } + + public static String join(Collection<String> collection) { return join(collection, ','); } Modified: tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java?rev=1789937&r1=1789936&r2=1789937&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/modeler/ManagedBean.java Mon Apr 3 09:56:06 2017 @@ -577,7 +577,7 @@ public class ManagedBean implements java private String createOperationKey(String methodName, String[] parameterTypes) { StringBuilder key = new StringBuilder(methodName); key.append('('); - StringUtils.join(parameterTypes); + StringUtils.join(parameterTypes, ',', key); key.append(')'); return key.toString(); Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1789937&r1=1789936&r2=1789937&view=diff ============================================================================== --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Mon Apr 3 09:56:06 2017 @@ -56,6 +56,10 @@ Correct various edge cases in the new HTTP Host header validation parser. Patch provided by Katya Todorova. (martk) </fix> + <fix> + Correct a regression in the X to comma refactoring that broke JMX + operations that take parameters. (markt) + </fix> </changelog> </subsection> <subsection name="Jasper"> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org