On Wed, Feb 8, 2017 at 6:17 PM, Mark Thomas <ma...@apache.org> wrote: > On 07/02/17 20:30, Mark Thomas wrote: >> >> Version 1.2.10 includes the following change: >> >> - Update minimum recommended OpenSSL version to 1.0.2k >> - Windows binaries built with OpenSSL 1.0.2k >> - Better documentation for building on Windows >> (including with FIPS enabled OpenSSL) >> >> The proposed release artefacts can be found at [1], >> and the build was done using tag [2]. >> >> The Apache Tomcat Native 1.2.11 is >> [ ] Stable, go ahead and release >> [X] Broken because of ... > > > I'm seeing intermittent crashes in the in the unit tests on Windows. > > As far as I can tell it is caused by the following: > - test 1 ends > - test 1 shuts down APR > - not all test 1 threads complete > - test 2 starts > - remaining test 1 threads complete > - remaining test 1 threads try to clean up thread-local memory > - crash as this memory was cleaned-up when APR for test 1 was shut down > > Liberal use of #if to remove all references to APR thread locals for the > Windows code and calling the OpenSSL clean-up directly seems to fix it. > > I am therefore cancelling this release vote. > > I should have a new RC ready in ~ 12 hours. > > Sorry for not spotting the problem sooner. >
I think the issue might have been in my original patch independent of OS. Looking at it again I think the initialization of the thread local should have been wrapped in something like apr_thread_once. However, I am not exactly sure how to correctly use the apr thread once api. It looks like you must first initialize the control using apr_thread_once_init however that does not have any safety preventing it from being called multiple times so I am not sure where that could be safely invoked, so that it is called once during the life of the process. On Linux I think it is not causing a major problem because the pthread thread local is just being initialized to a new slot so it is using extra thread local slots but doesn't cause crashes. Sorry, about that over site. -nate --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
