On 06/02/17 22:55, Mark Thomas wrote:
On 06/02/17 21:20, therealnewo...@gmail.com wrote:
Mark,
If there is anything I can do to help work on the patch I will,
however as I mentioned in the bug I don't have a windows environment
so I am basically useless if that is where the issues exist.
Yes, this is Windows.
The problem with the original approach was that DLL_THREAD_DETACH was
being called for all threads - including JVM threads stopping after the
native library had effectively closed down. Hence the crash.
I'm currently trying to use the same approach as used for Linux but I'm
not seeing the thread local being destroyed when the associated thread
exits. I'm still debugging why.
Any hints, suggestions etc. welcome.
Looking at the APR docs and source, the destructor function is only
called when apr_threadkey_private_delete is called and I don't see that
being called anywhere. How is this working on Linux? I suspect it isn't
but I haven't set up a build env to confirm that at this point.
Mark
Mark
-nate
On Mon, Feb 6, 2017 at 4:03 PM, Mark Thomas <ma...@apache.org> wrote:
On 06/02/17 21:01, ma...@apache.org wrote:
Author: markt
Date: Mon Feb 6 21:01:09 2017
New Revision: 1781952
URL: http://svn.apache.org/viewvc?rev=1781952&view=rev
Log:
Follow-up to r1781943
Fix build errors on Windows
Confirmed that terminated threads are removed from the hash
The patch isn't quite there yet. It triggers a JVM crash on shutdown
that
I'm currently looking at.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
