On 27/01/2017 14:08, Rémy Maucherat wrote: > 2017-01-27 10:55 GMT+01:00 <[email protected]>: > >> Author: markt >> Date: Fri Jan 27 09:55:04 2017 >> New Revision: 1780530 >> >> URL: http://svn.apache.org/viewvc?rev=1780530&view=rev >> Log: >> More refactoring of generated code so tags require less code >> Extract setters into a separate method when tag handling is in-lined in >> _jspService() >> > > I am now not convinced this is valid, since it breaks visibility with > expressions. Unfortunately :(
I see the problem. We could check all of the attributes to ensure that they are literals but my expectation is that most tags will have at least one attribute that is not a literal which makes the idea of extracting the setters into a separate method a lot less attractive. I'll revert the patch. I'm running out of ideas on ways to reduce the size of the _jspService() method. Suggestions welcome. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
