On 25/01/2017 20:30, Konstantin Kolinko wrote: > 2017-01-25 23:05 GMT+03:00 <ma...@apache.org>: >> Author: markt >> Date: Wed Jan 25 20:05:01 2017 >> New Revision: 1780262 >> >> URL: http://svn.apache.org/viewvc?rev=1780262&view=rev >> Log: >> Add a unit test used to investigate https://github.com/apache/tomcat85/pull/5 >> TagHandlerPool is effectively using a SynchronizedStack. This is known to >> perform better than ConcurrentLinkedDeque in some cases and testing >> confirmed that for TagHandlerPool. > > > 1. Rename to TestTagHandlerPoolPerformance ? > > In build.xml there is exclude pattern for such tests: > <exclude name="**/*Performance.java" if="${test.excludePerformance}" />
That would probably be more consistent. > 2. A test class with a single @Ignore'd method -> > I remember that in such case the annotation had to be moved to class level. > > (I do not remember the reason, but I think that we will see it soon enough.) I also remember the problem but not the reason. I was expecting the CI system to highlight the problem overnight. I'll do the rename. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
