Author: markt
Date: Mon Dec 5 11:46:51 2016
New Revision: 1772648
URL: http://svn.apache.org/viewvc?rev=1772648&view=rev
Log:
Mark remaining FindBugs warnings as false positives.
Modified:
tomcat/tc8.5.x/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/tc8.5.x/trunk/res/findbugs/filter-false-positives.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/res/findbugs/filter-false-positives.xml?rev=1772648&r1=1772647&r2=1772648&view=diff
==============================================================================
--- tomcat/tc8.5.x/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/tc8.5.x/trunk/res/findbugs/filter-false-positives.xml Mon Dec 5
11:46:51 2016
@@ -172,6 +172,12 @@
<Bug code="SWL" />
</Match>
<Match>
+ <!-- null return value is documented -->
+ <Class name="org.apache.catalina.core.StandardWrapper" />
+ <Method name="isSingleThreadModel" />
+ <Bug pattern="NP_BOOLEAN_RETURN_NULL" />
+ </Match>
+ <Match>
<!-- The code is adding HTTP request headers, not parameters and the
header parsing on input will have removed any CR or LF characters. -->
<Class name="org.apache.catalina.filters.CorsFilter" />
@@ -230,7 +236,12 @@
<Bug code="Dm" />
</Match>
<Match>
- <!-- The header value is safe -->
+ <!-- Name shadowing is intentional -->
+ <Class
name="org.apache.catalina.servlet4preview.http.HttpServletRequestWrapper"/>
+ <Bug pattern="NM_SAME_SIMPLE_NAME_AS_SUPERCLASS"/>
+ </Match>
+ <Match>
+ <!-- The header value is safe -->
<Class name="org.apache.catalina.servlets.DefaultServlet" />
<Method name="doDirectoryRedirect" />
<Bug pattern="HRS_REQUEST_PARAMETER_TO_HTTP_HEADER" />
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
