I can do that Felix.  I don't understand why the LF would be different in
zip vs tgz.  I mean, it seems whomever created the archives did it in two
different manners, either checking out the source in different systems, or
whatever, but shouldn't it be the same?  If a user wants to build on MAC,
or some other system that doesn't understand the LF character used, they
will receive an ambiguous error that doesn't really explain the problem.

I guess what I am saying is, "shouldn't it be consistent?"  It's not
crucial, I am just curious... I will move on to real bugs now =)  Thanks in
advance for your thoughts.

On Fri, Nov 4, 2016 at 3:14 PM, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:

>
>
> Am 4. November 2016 21:57:38 MEZ, schrieb Andrew Carr <
> andrewlanec...@gmail.com>:
> >So what did I do wrong?  Building from src-zip on mac is not the right
> >thing to do?  I mean, in the past I have just checked out the source or
> >updated trunk, is this the way it is meant to be?
>
> On a Mac use the tar.gz version instead of the zip.
>
> Regards,
>  Felix
> >
> >On Fri, Nov 4, 2016 at 2:30 PM, Mark Thomas <ma...@apache.org> wrote:
> >
> >> On 04/11/2016 20:28, Andrew Carr wrote:
> >> > Violeta, (Violeta is what my mother calls my daughter "Violet"), I
> >can do
> >> > that and will when I have a few minutes, but shouldn't the src.zip
> >have
> >> the
> >> > correct line formatting in it?
> >>
> >> CRLF is the correct line ending for the src zip.
> >>
> >> The src archives are set up for editing the source on the associated
> >> platform. The build script will ensure that the correct line endings
> >are
> >> configured in the release archives.
> >>
> >> Mark
> >>
> >>
> >> >
> >> > On Fri, Nov 4, 2016 at 12:34 PM, Violeta Georgieva
> ><violet...@apache.org
> >> >
> >> > wrote:
> >> >
> >> >> Hi,
> >> >>
> >> >> 2016-11-04 19:45 GMT+02:00 Andrew Carr <andrewlanec...@gmail.com>:
> >> >>>
> >> >>> In short:
> >> >>>
> >> >>>> The proposed 9.0.0.M13 release is:
> >> >>>> [ ] Broken - do not release
> >> >>>> [X] Alpha - go ahead and release as 9.0.0.M13
> >> >>>
> >> >>> However, on mac I ran into an issue with the ^M character being
> >in the
> >> >> .sh
> >> >>> files.  I would receive interpreter errors.  I have to remove all
> >of
> >> the
> >> >> ^M
> >> >>> characters from the .sh files in the bin folder, see below:
> >> >>>
> >> >>> *ACARR2:bin andrew.carr$ uname -a*
> >> >>>
> >> >>> *Darwin ACARR2.local 15.4.0 Darwin Kernel Version 15.4.0: Fri Feb
> >26
> >> >>> 22:08:05 PST 2016; root:xnu-3248.40.184~3/RELEASE_X86_64 x86_64*
> >> >>>
> >> >>> *ACARR2:apache-tomcat-9.0.0.M13-src andrew.carr$
> >> >>> output/build/bin/catalina.sh start*
> >> >>
> >> >> I can see that you are using the sources.
> >> >>
> >> >> I checked the sources and the binaries
> >> >> The file catalina.sh from apache-tomcat-9.0.0.M13.zip
> >> >> <https://dist.apache.org/repos/dist/dev/tomcat/tomcat-
> >> >> 9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13.zip>
> >> >> has
> >> >> LF as expected, but the catalina.sh from
> >apache-tomcat-9.0.0.M13-src.
> >> zip
> >> >> <https://dist.apache.org/repos/dist/dev/tomcat/tomcat-
> >> >> 9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.zip>
> >> >> has
> >> >> CRLF.
> >> >>
> >> >> Can you turn the file format to UNIX and check whether you will
> >see the
> >> >> issue?
> >> >>
> >> >> Regards,
> >> >> Violeta
> >> >>
> >> >>> *-bash: output/build/bin/catalina.sh: /bin/sh^M: bad interpreter:
> >No
> >> such
> >> >>> file or directory*
> >> >>>
> >> >>> *ACARR2:apache-tomcat-9.0.0.M13-src andrew.carr$ perl -i -pe
> >'y|\r||d'
> >> >>> output/build/bin/*.sh*
> >> >>>
> >> >>> *ACARR2:apache-tomcat-9.0.0.M13-src andrew.carr$
> >> >>> output/build/bin/catalina.sh start*
> >> >>>
> >> >>> *....Tomcat started.*
> >> >>> So, is this an issue or is this the way my mac is configured?
> >> >>>
> >> >>> ---
> >> >>> I also built on CentOS -
> >> >>>
> >> >>> *[root@andrewtest1 build]# uname -a*
> >> >>>
> >> >>> *Linux andrewtest1.openlogic.local 3.10.0-123.el7.x86_64 #1 SMP
> >Mon Jun
> >> >> 30
> >> >>> 12:09:22 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux*
> >> >>>
> >> >>> *[root@andrewtest1 build]# cat /etc/redhat-release *
> >> >>>
> >> >>> *CentOS Linux release 7.0.1406 (Core) *
> >> >>> And everything was good.
> >> >>>
> >> >>>
> >> >>> --
> >> >>> With Regards,
> >> >>> Andrew Carr
> >> >>>
> >> >>> e. andrewlanec...@gmail.com
> >> >>> w. andrew.c...@openlogic.com
> >> >>> h. 4235255668
> >> >>> c. 4239489206
> >> >>> a. P.O. Box 1231, Greeneville, TN, 37744
> >> >>>
> >> >>> On Fri, Nov 4, 2016 at 8:53 AM, Violeta Georgieva
> ><miles...@gmail.com>
> >> >>> wrote:
> >> >>>
> >> >>>> Hi,
> >> >>>>
> >> >>>> 2016-11-03 23:40 GMT+02:00 Mark Thomas <ma...@apache.org>:
> >> >>>>>
> >> >>>>> The proposed Apache Tomcat 9.0.0.M13 release is now available
> >for
> >> >> voting.
> >> >>>>>
> >> >>>>> This is a milestone release for the 9.0.x branch. It should be
> >> >>>>> noted that, as a milestone release:
> >> >>>>> - Servlet 4.0 is not finalised
> >> >>>>> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket
> >> >> 1.2/2.0
> >> >>>>>
> >> >>>>> 9.0.0.M13 corrects a regression reported in 9.0.0.M12.
> >> >>>>>
> >> >>>>> The major changes compared to the 9.0.0.M11 release are:
> >> >>>>>
> >> >>>>> - Implement header limits for HTTP/2
> >> >>>>>
> >> >>>>> - Improve handling of I/O errors with async processing
> >> >>>>>
> >> >>>>> - Fail earlier on invalid HTTP requests
> >> >>>>>
> >> >>>>> Along with lots of other bug fixes and improvements
> >> >>>>>
> >> >>>>> For full details, see the changelog:
> >> >>>>>
> >> >>
> >http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
> >> >>>>>
> >> >>>>> It can be obtained from:
> >> >>>>>
> >https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M13/
> >> >>>>> The Maven staging repo is:
> >> >>>>>
> >> >> https://repository.apache.org/content/repositories/
> >> orgapachetomcat-1103/
> >> >>>>> The svn tag is:
> >> >>>>> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M13/
> >> >>>>>
> >> >>>>> The proposed 9.0.0.M13 release is:
> >> >>>>> [ ] Broken - do not release
> >> >>>>> [X] Alpha - go ahead and release as 9.0.0.M13
> >> >>>>
> >> >>>> +1 my tests passed
> >> >>>>
> >> >>>> Regards,
> >> >>>> Violeta
> >> >>>>
> >> >>>>> ------------------------------------------------------------
> >> >> ---------
> >> >>>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >> >>>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >> >>>>>
> >> >>>>
> >> >>
> >> >
> >> >
> >> >
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


-- 
With Regards,
Andrew Carr

e. andrewlanec...@gmail.com
w. andrew.c...@openlogic.com
h. 4235255668
c. 4239489206
a. P.O. Box 1231, Greeneville, TN, 37744

Reply via email to