On Sat, Oct 15, 2016 at 5:26 PM, Rémy Maucherat <r...@apache.org> wrote:
> 2016-10-15 11:17 GMT+02:00 Martin Grigorov <mgrigo...@apache.org>:
>
> > Hi Remy,
> >
> > On Fri, Oct 14, 2016 at 3:46 PM, <r...@apache.org> wrote:
> > > return (logger);
> > > - logger = LogFactory.getLog(logName());
> > > + logger = LogFactory.getLog(getLogName());
> > >
> >
> > What would be the behavior here if #getLogName() returns null ?
> >
>
> It's bad and would cause NPEs.
>
> >
> > > @Override
> > > + public String getLogName() { return null; }
> > >
> >
> > Maybe it is better to return something like "FailedContextLog" instead ?!
> > This is related to the first question above.
> >
>
> It's not used, and if it is it will cause a NPE like getLogger.
>
If it is never used then it is OK!
Thanks!
>
> Rémy
>
