Author: markt
Date: Thu Aug 25 13:38:28 2016
New Revision: 1757684

URL: http://svn.apache.org/viewvc?rev=1757684&view=rev
Log:
Small logging optimization
Patch provided by Svetlin Zarev

Modified:
    tomcat/trunk/java/org/apache/tomcat/util/http/Rfc6265CookieProcessor.java
    tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/http/Rfc6265CookieProcessor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/Rfc6265CookieProcessor.java?rev=1757684&r1=1757683&r2=1757684&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/http/Rfc6265CookieProcessor.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/http/Rfc6265CookieProcessor.java 
Thu Aug 25 13:38:28 2016
@@ -73,9 +73,11 @@ public class Rfc6265CookieProcessor impl
 
             if (cookieValue != null && !cookieValue.isNull() ) {
                 if (cookieValue.getType() != MessageBytes.T_BYTES ) {
-                    Exception e = new Exception();
-                    // TODO: Review this in light of HTTP/2
-                    log.debug("Cookies: Parsing cookie as String. Expected 
bytes.", e);
+                    if (log.isDebugEnabled()) {
+                        Exception e = new Exception();
+                        // TODO: Review this in light of HTTP/2
+                        log.debug("Cookies: Parsing cookie as String. Expected 
bytes.", e);
+                    }
                     cookieValue.toBytes();
                 }
                 if (log.isDebugEnabled()) {

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1757684&r1=1757683&r2=1757684&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Aug 25 13:38:28 2016
@@ -217,6 +217,10 @@
         configuration attribute does not depend on the presence of a 
certificate
         revokation list. (markt)
       </fix>
+      <fix>
+        Small logging optimization in the <code>Rfc6265CookieProcessor</code>.
+        Patch provided by Svetlin Zarev. (markt)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Jasper">



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to