Author: olamy
Date: Tue Aug 16 01:05:58 2016
New Revision: 1756453
URL: http://svn.apache.org/viewvc?rev=1756453&view=rev
Log:
minor updates
Modified:
tomcat/maven-plugin/trunk/pom.xml
tomcat/maven-plugin/trunk/tomcat-maven-plugin-it/src/main/java/org/apache/tomcat/maven/it/AbstractWarProjectIT.java
tomcat/maven-plugin/trunk/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java
Modified: tomcat/maven-plugin/trunk/pom.xml
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/pom.xml?rev=1756453&r1=1756452&r2=1756453&view=diff
==============================================================================
--- tomcat/maven-plugin/trunk/pom.xml (original)
+++ tomcat/maven-plugin/trunk/pom.xml Tue Aug 16 01:05:58 2016
@@ -640,12 +640,12 @@
<dependency>
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-verifier</artifactId>
- <version>1.4</version>
+ <version>1.5</version>
</dependency>
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
- <version>4.3.1</version>
+ <version>4.3.5</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
@@ -660,12 +660,12 @@
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-core</artifactId>
- <version>2.0-beta9</version>
+ <version>2.0.1</version>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
- <version>2.0-beta9</version>
+ <version>2.0.1</version>
</dependency>
</dependencies>
</dependencyManagement>
Modified:
tomcat/maven-plugin/trunk/tomcat-maven-plugin-it/src/main/java/org/apache/tomcat/maven/it/AbstractWarProjectIT.java
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat-maven-plugin-it/src/main/java/org/apache/tomcat/maven/it/AbstractWarProjectIT.java?rev=1756453&r1=1756452&r2=1756453&view=diff
==============================================================================
---
tomcat/maven-plugin/trunk/tomcat-maven-plugin-it/src/main/java/org/apache/tomcat/maven/it/AbstractWarProjectIT.java
(original)
+++
tomcat/maven-plugin/trunk/tomcat-maven-plugin-it/src/main/java/org/apache/tomcat/maven/it/AbstractWarProjectIT.java
Tue Aug 16 01:05:58 2016
@@ -22,12 +22,12 @@ package org.apache.tomcat.maven.it;
import org.apache.http.HttpResponse;
import org.apache.http.client.ResponseHandler;
+import org.apache.http.client.config.RequestConfig;
import org.apache.http.client.methods.HttpGet;
import org.apache.http.client.methods.HttpHead;
import org.apache.http.impl.client.BasicResponseHandler;
-import org.apache.http.impl.client.DefaultHttpClient;
-import org.apache.http.params.HttpConnectionParams;
-import org.apache.http.params.HttpParams;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClientBuilder;
import org.apache.maven.it.VerificationException;
import org.apache.maven.it.Verifier;
import org.apache.maven.it.util.ResourceExtractor;
@@ -67,7 +67,7 @@ public abstract class AbstractWarProject
/**
* HttpClient to use to connect to the deployed web-application.
*/
- private DefaultHttpClient httpClient;
+ private CloseableHttpClient httpClient;
/**
* Helper for Maven-Integration-Tests.
@@ -83,11 +83,8 @@ public abstract class AbstractWarProject
public void setUp()
throws Exception
{
- httpClient = new DefaultHttpClient();
- final HttpParams params = httpClient.getParams();
- HttpConnectionParams.setConnectionTimeout( params, getTimeout() );
- HttpConnectionParams.setSoTimeout( params, getTimeout() );
+ httpClient = HttpClientBuilder.create().build();
webappHome = ResourceExtractor.simpleExtractResources( getClass(), "/"
+ getWarArtifactId() );
verifier = new Verifier( webappHome.getAbsolutePath() );
@@ -105,7 +102,7 @@ public abstract class AbstractWarProject
public void tearDown()
throws Exception
{
- httpClient.getConnectionManager().shutdown();
+ httpClient.close();
verifier.resetStreams();
verifier.deleteArtifact( "org.apache.tomcat.maven.it",
getWarArtifactId(), "1.0-SNAPSHOT", "war" );
}
@@ -198,6 +195,8 @@ public abstract class AbstractWarProject
throws IOException
{
HttpGet httpGet = new HttpGet( getWebappUrl() );
+ httpGet.setConfig(
+ RequestConfig.custom().setSocketTimeout( getTimeout()
).setConnectTimeout( getTimeout() ).build() );
ResponseHandler<String> responseHandler = new BasicResponseHandler();
return httpClient.execute( httpGet, responseHandler );
}
Modified:
tomcat/maven-plugin/trunk/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java
URL:
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java?rev=1756453&r1=1756452&r2=1756453&view=diff
==============================================================================
---
tomcat/maven-plugin/trunk/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java
(original)
+++
tomcat/maven-plugin/trunk/tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java
Tue Aug 16 01:05:58 2016
@@ -359,16 +359,21 @@ public class RunMojo
url = pluginRealm.getResource(
StringUtils.removeStart( path, "/" ) );
}
- // try in reactors
- List<WebResource> webResources =
findResourcesInDirectories( path, //
-
classLoaderEntriesCalculatorResult.getBuildDirectories() );
-
- // so we return the first one
- if ( !webResources.isEmpty() )
+ if (url == null)
{
- return webResources.get( 0 );
+ // try in reactors
+ List<WebResource> webResources =
findResourcesInDirectories( path, //
+
classLoaderEntriesCalculatorResult.getBuildDirectories() );
+
+ // so we return the first one
+ if ( !webResources.isEmpty() )
+ {
+ return webResources.get( 0 );
+ }
}
+
+
if ( url == null )
{
return new EmptyResource( this, getPath() );
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
