On 06/07/2016 11:32, Konstantin Kolinko wrote:
> 2016-07-05 16:59 GMT+03:00  <ma...@apache.org>:
>> Author: markt
>> Date: Tue Jul  5 13:59:14 2016
>> New Revision: 1751479
>>
>> URL: http://svn.apache.org/viewvc?rev=1751479&view=rev
>> Log:
>> Use UTF-8 with a standard prolog for all XML files.
>>

<snip/>

> Modified: 
> tomcat/tc8.5.x/trunk/java/org/apache/jasper/resources/LocalStrings.properties
> URL: 
> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/jasper/resources/LocalStrings.properties?rev=1751479&r1=1751478&r2=1751479&view=diff
> ==============================================================================
> --- 
> tomcat/tc8.5.x/trunk/java/org/apache/jasper/resources/LocalStrings.properties
> (original)
> +++ 
> tomcat/tc8.5.x/trunk/java/org/apache/jasper/resources/LocalStrings.properties
> Tue Jul  5 13:59:14 2016
> @@ -187,7 +187,7 @@ where options include:\n\
>  \    -source <version>   Set the -source argument to the compiler
> (default 1.7)\n\
>  \    -target <version>   Set the -target argument to the compiler
> (default 1.7)\n\
> 
> -jspc.webxml.header=<?xml version="1.0" encoding="ISO-8859-1"?>\n\
> +jspc.webxml.header=<?xml version="1.0" encoding="UTF-8"?>\n\
>  \n\
>  <!DOCTYPE web-app\n\
>  \    PUBLIC "-//Sun Microsystems, Inc.//DTD Web Application 2.3//EN"\n\
> 
> 
> + same change in localized files.
> 
> The above change means that JspC has to use UTF-8 to write the file.
> 
> Looking into JspC.java, it looks that the default is system encoding,
> not UTF-8 and not ISO-8859-1 either. So the old header was wrong as
> well.

I started by switching the remaining i18n files to UTF-8 but when I
looked into the encoding used by the output stream I realised the
encoding was configurable so it never should have been hard coded in the
first place.

This should be fixed in 9.0.x and 8.5.x now.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to