https://bz.apache.org/bugzilla/show_bug.cgi?id=59716

            Bug ID: 59716
           Summary: Allow JNDI configuration of CorsFilter
           Product: Tomcat 7
           Version: 7.0.69
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: lucasthei...@apache.org

Created attachment 33957
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33957&action=edit
Source code for the delegating filter and integration test.

Currently the CorsFilter is configured by init-param's.  This makes
configuration compile time (as it would be stored in the deployment artifact). 
In my experience, CORS configuration is environmental (I have a different set
of allowed origins based on where I deploy my app: dev/qa/production), and as
such should be runtime.  Pushing config to JNDI (or at least allowing override
in JNDI) allows you to configure the same artifact differently depending on
environment.  I have written a filter that delegates to the CorsFilter to allow
for JNDI config (which i will attach), but it would be quite simple and useful
to move this functionality into the core filter.  I would be willing to patch
the filter as well if you are interested in this approach...

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to