DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=40420>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=40420 Summary: gaps in logic of org.apache.jasper.compiler.Compiler.isOutDated() Product: Tomcat 5 Version: 5.5.9 Platform: All OS/Version: other Status: NEW Severity: normal Priority: P2 Component: Jasper AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] Hi guys, i've been meaning to report this problem quite a while ago but it is better late then never... so here it goes: We have a deployment system based on the back of Subversion, which facilitates rolling application back as well as forward. The system also maintains file dates to be consistent with the dates in the repository. We started noticing problems when Tomcat would choose not to compile JSPs that have been updated. On the closer inspection it appears that isOutDated() function would return as positive only if targetLastModified < jspLastModified, which is not always the case when JSP files are rolled back in time. I think it would be more accurate to compile the JSP if "targetLastModified != jspLastModified" and when the generated servlet and the compiled class have the same "lastModified" value as the source JSP file. There is also more complicated problem to fix, which is to do with how "include" files affect isOutDated() function. isOutDated() should be called recursively on the included files instead of comparing their dates to the master jsp date. I'd be happy to submit a patch should you want me to. Regards, Vlad -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]