Author: markt
Date: Fri Apr 29 16:32:21 2016
New Revision: 1741661
URL: http://svn.apache.org/viewvc?rev=1741661&view=rev
Log:
Clean-up
- remove completed TODOs
- remove pointless Javadoc
Modified:
tomcat/trunk/java/org/apache/catalina/connector/ResponseFacade.java
tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
tomcat/trunk/java/org/apache/catalina/ha/ClusterMessageBase.java
tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
tomcat/trunk/java/org/apache/catalina/tribes/io/DirectByteArrayOutputStream.java
tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/PooledMultiSender.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/ResponseFacade.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/ResponseFacade.java?rev=1741661&r1=1741660&r2=1741661&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/connector/ResponseFacade.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/connector/ResponseFacade.java Fri Apr
29 16:32:21 2016
@@ -219,29 +219,22 @@ public class ResponseFacade
@Override
public void setContentLength(int len) {
-
if (isCommitted()) {
return;
}
-
response.setContentLength(len);
-
}
- /**
- * TODO SERVLET 3.1
- */
@Override
public void setContentLengthLong(long length) {
if (isCommitted()) {
return;
}
-
response.setContentLengthLong(length);
-
}
+
@Override
public void setContentType(String type) {
Modified: tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java?rev=1741661&r1=1741660&r2=1741661&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java Fri Apr 29
16:32:21 2016
@@ -124,8 +124,6 @@ import org.apache.tomcat.util.res.String
* Subclasses that fire additional events should document them in the
* class comments of the implementation class.
*
- * TODO: Review synchronisation around background processing. See bug 47024.
- *
* @author Craig R. McClanahan
*/
public abstract class ContainerBase extends LifecycleMBeanBase
Modified: tomcat/trunk/java/org/apache/catalina/ha/ClusterMessageBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/ClusterMessageBase.java?rev=1741661&r1=1741660&r2=1741661&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/ha/ClusterMessageBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/ha/ClusterMessageBase.java Fri Apr 29
16:32:21 2016
@@ -22,18 +22,13 @@ public abstract class ClusterMessageBase
private static final long serialVersionUID = 1L;
- protected transient Member address;
private long timestamp;
+ protected transient Member address;
+
public ClusterMessageBase() {
// NO-OP
}
- /**
- * getAddress
- *
- * @return Member
- * TODO Implement this org.apache.catalina.ha.ClusterMessage method
- */
@Override
public Member getAddress() {
return address;
@@ -44,12 +39,6 @@ public abstract class ClusterMessageBase
return timestamp;
}
- /**
- * setAddress
- *
- * @param member Member
- * TODO Implement this org.apache.catalina.ha.ClusterMessage method
- */
@Override
public void setAddress(Member member) {
this.address = member;
Modified: tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java?rev=1741661&r1=1741660&r2=1741661&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java Fri
Apr 29 16:32:21 2016
@@ -1088,7 +1088,6 @@ public final class HTMLManagerServlet ex
}
};
}
- //TODO: complete this to TTL, etc.
return comparator;
}
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/io/DirectByteArrayOutputStream.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/DirectByteArrayOutputStream.java?rev=1741661&r1=1741660&r2=1741661&view=diff
==============================================================================
---
tomcat/trunk/java/org/apache/catalina/tribes/io/DirectByteArrayOutputStream.java
(original)
+++
tomcat/trunk/java/org/apache/catalina/tribes/io/DirectByteArrayOutputStream.java
Fri Apr 29 16:32:21 2016
@@ -40,7 +40,6 @@ public class DirectByteArrayOutputStream
* @throws IOException if an I/O error occurs. In particular, an
* <code>IOException</code> may be thrown if the output stream has
* been closed.
- * TODO Implement this java.io.OutputStream method
*/
@Override
public void write(int b) throws IOException {
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/PooledMultiSender.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/PooledMultiSender.java?rev=1741661&r1=1741660&r2=1741661&view=diff
==============================================================================
---
tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/PooledMultiSender.java
(original)
+++
tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/PooledMultiSender.java
Fri Apr 29 16:32:21 2016
@@ -53,18 +53,10 @@ public class PooledMultiSender extends P
}
}
- /**
- * getNewDataSender
- *
- * @return DataSender
- * TODO Implement this org.apache.catalina.tribes.transport.PooledSender
- * method
- */
@Override
public DataSender getNewDataSender() {
MultipointBioSender sender = new MultipointBioSender();
AbstractSender.transferProperties(this,sender);
return sender;
}
-
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
