On 23/04/2016 04:01, Abdessamed MANSOURI wrote: > I saw your modification on the code, but i really didn't understand the > idea behind it, in previous days, i tried to debug it, but really i didn't > figure where is the problem, if you have time, just explain to what you > have done :)
The fix isn't right yet. What I am trying to do is detect when async has been started in Servlet.service() and then an exception is thrown before Servlet.service() exists. In that case, we need to trigger Async error handling. The problem, as you have observed elsewhere, is that in some cases onError() is called twice. Current I added code the ErrorReportValve to trigger onError() but the criteria I used are not selective enough. I either need find better criteria or more the test. I'm currently leaning towards moving the test. Mark > > 2016-04-20 11:34 GMT+01:00 Mark Thomas <ma...@apache.org>: > >> On 19/04/2016 23:44, Abdessamed MANSOURI wrote: >>> I think, i just have to write a simple test case which is pretty similair >>> to TestAsyncContextImpl.testListeners, or not?? :) >> >> Correct. You are heading in the right direction. >> >> You can use the existing test cases in TestAsyncContextImpl and the test >> case provided in Bug 59219 as a guide. >> >> There should be a lot of code in TestAsyncContextImpl you can re-use >> and/or extend slightly to do what you need. >> >> Don't worry about your first proposal being perfect. Get something that >> works and we can provide you with feedback. Also, don't worry if you get >> a lot of feedback and you end up changing most or even all of your >> patch. The first patch I proposed was completely unrecognisable by the >> time it actually made it into the Tomcat code base. >> >> Mark >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
