On 30/03/2016 21:43, Mark Thomas wrote: > On 30/03/2016 21:31, Caldarale, Charles R wrote: >>> From: Mark Thomas [mailto:ma...@apache.org] >>> Subject: Re: svn commit: r1737154 - in /tomcat/native/trunk: >>> native/src/sslcontext.c xdocs/miscellaneous/changelog.xml >> >>> The implementation is essentially a copy/paste of setCertificateRaw with >>> what looked to be the right changes to remove the unnecessary private >>> key code and to call the right OpenSSL method to set the chain. >> >>> It does work - in that SSL Labs sees the full chain - but the code may >>> well be terrible. I wouldn't be surprised if it leaked memory. >> >> I don't see any obvious leaks (although I'm unfamiliar with OpenSSL >> semantics), > > ACK. Thanks. > >> but using a goto is generally frowned upon. Better code might be something >> like this: > > My defence is that I was copying the style of the previous method. If we > fix one, we should fix both. I'll see what I can do.
It is easy to drop the goto in this method. The previous method not so much so I did just fix the one. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
