https://bz.apache.org/bugzilla/show_bug.cgi?id=59138
--- Comment #6 from Christopher Schultz <ch...@christopherschultz.net> --- (In reply to Mark Thomas from comment #5) > > However, we have had issues reported where objects being retained after web > application stop until the next GC has been sufficient to cause problems. If > memory serves me correctly, those were all JDBC related. In this case, I > don't think that will be an issue. Currently, ThreadLocal issues are cleaned > up by renewing the thread pool and that won't change with the proposed > change. All that changes is that keys won't trigger the warning messages. > > We could log issues with keys at debug level on the grounds that users might > find it useful. That will complicate the code though. I'm not sure that is > worth doing. I'll think about it over night and come back to this tomorrow. I think a downgrade from SEVERE to ... something else is appropriate. Maybe not as low as DEBUG; perhaps INFO? AFAIK, there's no way for Java code to ask the JVM if a reference is only strongly reachable from a particular root (e.g. the ThreadLocalMap itself), so there's no way for Tomcat to prove that the application-loaded ThreadLocal can be collected after the ClassLoader is (otherwise) free. So there is certainly ample opportunity for a memory leak, here, and users should be notified about it. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
